Improve permalink on thread root message #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Apr 5, 2022
| eventId | ||
| } else { | ||
| null | ||
| } |
There was a problem hiding this comment.
I understand the code and it should work, hence it's a bit confusing to have multiple declaration of val rootThreadEventId. Not a blocker anyway.
There was a problem hiding this comment.
True, I could use another naming convention
ariskotsomitopoulos
deleted the
feature/aris/thread_root_permalink_navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permalinks to root thread messages will now navigate the user within the thread timeline
Closes #5567